Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(SPM-1798): discuss OCI authentication in documentation #11

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

kolbeinn
Copy link
Contributor

Summary

Updating the module documentation with more explicit instructions on how to provide credentials to the OCI Terraform provider.

How did you test this change?

There's no real logic change here, so the tests in the CI pipeline should be sufficient.

Issue

SPM-1798

Signed-off-by: Kolbeinn Karlsson <kolbeinn.karlsson@lacework.net>
@kolbeinn kolbeinn changed the title docs(SPM-1798: mention OCI authentication in documentation docs(SPM-1798): discuss OCI authentication in documentation Nov 1, 2023
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question about the difference between two examples. But should be good to merge

Signed-off-by: Kolbeinn Karlsson <kolbeinn.karlsson@lacework.net>
@kolbeinn kolbeinn merged commit 9d56ff0 into main Nov 1, 2023
2 checks passed
@kolbeinn kolbeinn deleted the better-examples branch November 1, 2023 16:11
@lacework-releng lacework-releng mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants